Add a setting type with setting_type, and humidity #139

Merged

Claude merged 5 commits from feat/yaml-climate into feat/yaml-nodes

2026-10-17 19:46:27 +00:00

Claude commented

2026-10-17 08:41:27 +00:00

Collaborator

YN-20, reworked after review. Stacks on #137 (YN-19, optional endpoint index), so the diff also shows that PR's commits until it merges.

The four setting types become one endpoint type, setting, with a required setting_type of toggle, duration, percentage or temperature. The fields per setting type are what they were: default (a bool) for toggle, and min, max and default with the existing ranges and scales for the other three. toggle, duration and percentage were already on feat/yaml-nodes, so this PR renames them too; the old names are no longer endpoint types. Every reference by label (enabled_by, hold, night_brightness, the bind on_delay and run_time) now checks setting_type instead of the endpoint type. The generated C++ is unchanged.

temperature is the new setting type: a ctrl::SettingEndpoint with can::SemanticClass::Temperature, on the node's store with the usual s<index> key. YAML values are degrees Celsius, 0 to 120, to one decimal place (18.55 is rejected), and go on the wire as tenths. The range settings share one table of semantic class and wire scale.

Humidity is unchanged: a ctrl::ReadoutEndpoint of can::EndpointType::Humidity reading climateSensor.humidity() from the Si7021 that the temperature sensor type declares. It takes no pin, at most one is allowed, and it needs a temperature endpoint on the node.

The schema has one setting entry per setting_type (each branch fixes setting_type and lists only that kind's fields), so the property lists stay exact. README has one setting row and a Settings section with a setting_type table. The three fixtures use the new form, and the C3 fixture also has a temperature sensor, humidity and a temperature setting.

Tested: Python 103 (was 100 before this rework) and all fixtures build, none skipped locally. New tests cover a missing or unknown setting_type, the old names being rejected as types, and the schema requiring setting_type; the existing setting, reference and render tests were moved to the new form.

YN-20, reworked after review. Stacks on #137 (YN-19, optional endpoint index), so the diff also shows that PR's commits until it merges. The four setting types become one endpoint type, `setting`, with a required `setting_type` of `toggle`, `duration`, `percentage` or `temperature`. The fields per setting type are what they were: `default` (a bool) for `toggle`, and `min`, `max` and `default` with the existing ranges and scales for the other three. `toggle`, `duration` and `percentage` were already on feat/yaml-nodes, so this PR renames them too; the old names are no longer endpoint types. Every reference by label (`enabled_by`, `hold`, `night_brightness`, the bind `on_delay` and `run_time`) now checks `setting_type` instead of the endpoint type. The generated C++ is unchanged. `temperature` is the new setting type: a `ctrl::SettingEndpoint` with `can::SemanticClass::Temperature`, on the node's store with the usual `s<index>` key. YAML values are degrees Celsius, 0 to 120, to one decimal place (18.55 is rejected), and go on the wire as tenths. The range settings share one table of semantic class and wire scale. Humidity is unchanged: a `ctrl::ReadoutEndpoint` of `can::EndpointType::Humidity` reading `climateSensor.humidity()` from the Si7021 that the `temperature` sensor type declares. It takes no pin, at most one is allowed, and it needs a `temperature` endpoint on the node. The schema has one `setting` entry per `setting_type` (each branch fixes `setting_type` and lists only that kind's fields), so the property lists stay exact. README has one `setting` row and a Settings section with a `setting_type` table. The three fixtures use the new form, and the C3 fixture also has a temperature sensor, humidity and a temperature setting. Tested: Python 103 (was 100 before this rework) and all fixtures build, none skipped locally. New tests cover a missing or unknown `setting_type`, the old names being rejected as types, and the schema requiring `setting_type`; the existing setting, reference and render tests were moved to the new form.

Claude added 3 commits

2026-10-17 08:41:28 +00:00