Add a flow5d type for the Autoterm Flow 5D heater #140

Merged

Claude merged 4 commits from feat/yaml-flow5d into feat/yaml-nodes

2026-10-17 19:46:30 +00:00

Claude commented

2026-10-17 08:55:55 +00:00

Collaborator

YN-21. Stacks on #139 (YN-20), which stacks on #137 (YN-19), so the diff also shows their commits until those merge.

New output type flow5d: rx and tx pins, label, optional diagnostics (default false) and binds. It must be the endpoint at index 0 and is a block that occupies 0 to 25 (its span is 26, so the next endpoint without an index takes 26). It registers the same children at the same indices with the same labels as src/node_heater/main.cpp: heater 0, exchanger 1, supply 2, second coolant 3, coolant return 4, minutes since start 5, blower flag 6, run time 7, preheater wait 9, warm-up wait 10, coolant 23, and with diagnostics: true the eight diagnostics 17 to 22, 24 and 25 (marked with setDiagnostic()). Their indices stay reserved when diagnostics are off, and 8 and 11 to 16 stay free. Another endpoint on a reserved index fails naming the child ("3 is already used by the 'Coolant temperature 2' child of the flow5d"), and a registered child's label is reserved too. XIAO boards only; the LOLIN32 is rejected, and the schema refuses it too.

The generator emits what main.cpp has: the shared PreferencesStore, the three SettingEndpoints (keys s7, s9, s10), autoterm::Flow5D, the statusOf/reading helpers, the readouts and the two FlagInputs, Serial1.begin(2400, ...) and flow5d.begin() in setup, and the Serial1 feed plus flow5d.loop in loop. HeaterEndpoint takes flow5d as its device, and its measured reading is can::SensorScalar{} (Unknown) until the measure bind exists. The blower motor, climate sensor, water heating and arbiter are not part of the type. The blower output and link children can be bind sources by label or index.

Runtime: two small touches so binds can target a heater. strategyFor gains EndpointType::Heater, and HeaterEndpoint::isOn() reports whether heat is wanted, which is what mode() reports as Heat, so a toggle bind stops a heater it started as well as starting it. The endpoint takes no disabled_modes; binds keep theirs.

Schema regenerated (rx/tx enums per board), README gets a Flow 5D section with the child table, and a new heater.yaml fixture compiles the block with diagnostics and a following bind.

Tested: Python 113 (was 100) and native 639, none skipped locally. Native tests cover a follow bind starting and stopping the device, and a toggle bind starting it then stopping it; removing the isOn() override fails the toggle test. Hiding the diagnostics wrongly fails two Python tests. All fixtures and pio run build.

YN-21. Stacks on #139 (YN-20), which stacks on #137 (YN-19), so the diff also shows their commits until those merge. New output type `flow5d`: `rx` and `tx` pins, `label`, optional `diagnostics` (default false) and `binds`. It must be the endpoint at index 0 and is a block that occupies 0 to 25 (its `span` is 26, so the next endpoint without an `index` takes 26). It registers the same children at the same indices with the same labels as src/node_heater/main.cpp: heater 0, exchanger 1, supply 2, second coolant 3, coolant return 4, minutes since start 5, blower flag 6, run time 7, preheater wait 9, warm-up wait 10, coolant 23, and with `diagnostics: true` the eight diagnostics 17 to 22, 24 and 25 (marked with `setDiagnostic()`). Their indices stay reserved when diagnostics are off, and 8 and 11 to 16 stay free. Another endpoint on a reserved index fails naming the child ("3 is already used by the 'Coolant temperature 2' child of the flow5d"), and a registered child's label is reserved too. XIAO boards only; the LOLIN32 is rejected, and the schema refuses it too. The generator emits what main.cpp has: the shared `PreferencesStore`, the three `SettingEndpoint`s (keys `s7`, `s9`, `s10`), `autoterm::Flow5D`, the `statusOf`/`reading` helpers, the readouts and the two `FlagInput`s, `Serial1.begin(2400, ...)` and `flow5d.begin()` in setup, and the `Serial1` feed plus `flow5d.loop` in loop. `HeaterEndpoint` takes `flow5d` as its device, and its measured reading is `can::SensorScalar{}` (Unknown) until the measure bind exists. The blower motor, climate sensor, water heating and arbiter are not part of the type. The blower output and link children can be bind sources by label or index. Runtime: two small touches so binds can target a heater. `strategyFor` gains `EndpointType::Heater`, and `HeaterEndpoint::isOn()` reports whether heat is wanted, which is what `mode()` reports as Heat, so a `toggle` bind stops a heater it started as well as starting it. The endpoint takes no `disabled_modes`; binds keep theirs. Schema regenerated (`rx`/`tx` enums per board), README gets a Flow 5D section with the child table, and a new `heater.yaml` fixture compiles the block with diagnostics and a following bind. Tested: Python 113 (was 100) and native 639, none skipped locally. Native tests cover a follow bind starting and stopping the device, and a toggle bind starting it then stopping it; removing the `isOn()` override fails the toggle test. Hiding the diagnostics wrongly fails two Python tests. All fixtures and `pio run` build.

Claude added 6 commits

2026-10-17 08:55:55 +00:00