Indent with tabs

rob commented

2026-08-03 17:44:40 +00:00

Owner

indent_style = tab on the root [*] rule, so the house rule is stated once and the exceptions are enumerated with reasons: YAML and JSON keep spaces (tabs are invalid in YAML), .md keeps spaces (a leading tab is a code block in CommonMark), and .sql keeps spaces because a merged script is immutable under ADR-0021, so tabs would reach only new scripts and leave the rule disagreeing with every script in the tree.

The indent_size = 2 rule for build files is deleted, not updated — with tabs, "two for build files, four for code" has nothing left to express, and leaving it would silently have meant something else.

Whitespace only, proven three ways rather than asserted:

git diff --ignore-all-space is empty outside .editorconfig, and every file has identical added/deleted counts.
That check is blind to whitespace inside strings, so a Roslyn tool dumped ValueText for every string and char literal in all 47 .cs files before and after: 668 literal values byte-identical.
dotnet format --verify-no-changes exits 0 before, 2 after the .editorconfig edit alone, 0 after the sweep. CI already runs that command, so this is enforced rather than advisory.

dotnet format reaches .cs only — the .razor files came out byte-identical, so those, plus .csproj/.props/.slnx, .css and index.html, were converted by hand. Continuation lines that align under text above them are padded with spaces so the alignment survives any tab width; the XML comment continuations in four .csproj files needed correcting after naive unit division put them four tabs deep.

Worth knowing: dotnet format does not touch the interior of a multi-line raw string literal, so the SQL in DatabaseSeeder.cs and three test files keeps its 8-space body — the only space indentation left in any .cs file. Reindenting those interiors by hand is precisely the operation that silently changes a string, so it was not done. At tab_width = 4 they render as before; at any other width the body no longer lines up under its declaration.

Release build 0 warnings, 123 tests pass.

`indent_style = tab` on the root `[*]` rule, so the house rule is stated once and the exceptions are enumerated with reasons: YAML and JSON keep spaces (tabs are invalid in YAML), `.md` keeps spaces (a leading tab is a code block in CommonMark), and `.sql` keeps spaces because a merged script is immutable under ADR-0021, so tabs would reach only new scripts and leave the rule disagreeing with every script in the tree. The `indent_size = 2` rule for build files is **deleted**, not updated — with tabs, "two for build files, four for code" has nothing left to express, and leaving it would silently have meant something else. Whitespace only, proven three ways rather than asserted: - `git diff --ignore-all-space` is empty outside `.editorconfig`, and every file has identical added/deleted counts. - That check is blind to whitespace *inside* strings, so a Roslyn tool dumped `ValueText` for every string and char literal in all 47 `.cs` files before and after: **668 literal values byte-identical**. - `dotnet format --verify-no-changes` exits 0 before, 2 after the `.editorconfig` edit alone, 0 after the sweep. CI already runs that command, so this is enforced rather than advisory. `dotnet format` reaches `.cs` only — the `.razor` files came out byte-identical, so those, plus `.csproj`/`.props`/`.slnx`, `.css` and `index.html`, were converted by hand. Continuation lines that align under text above them are padded with spaces so the alignment survives any tab width; the XML comment continuations in four `.csproj` files needed correcting after naive unit division put them four tabs deep. Worth knowing: `dotnet format` does not touch the interior of a multi-line raw string literal, so the SQL in `DatabaseSeeder.cs` and three test files keeps its 8-space body — the only space indentation left in any `.cs` file. Reindenting those interiors by hand is precisely the operation that silently changes a string, so it was not done. At `tab_width = 4` they render as before; at any other width the body no longer lines up under its declaration. Release build 0 warnings, 123 tests pass.

rob added 1 commit

2026-08-03 17:44:40 +00:00

Indent with tabs

CI / build (pull_request) Successful in 1m10s

Details

ea28fc2c40

A tab makes the width of an indentation level the reader's setting rather
than the author's. `.editorconfig` says `indent_style = tab` at the root,
with `tab_width` and `indent_size` both 4 so the two knobs different tools
read cannot disagree, and `dotnet format` has applied it across the
solution. CI already runs `dotnet format --verify-no-changes`, so this is
enforced from here rather than advisory.

Four formats opt out, each with its reason in the file. YAML, because a
tab is not legal indentation there and the parser refuses the file. JSON,
because we are not its only author — the templates that scaffold
appsettings.json and the editor that rewrites launchSettings.json emit two
spaces, and nothing in this build reformats them back. Markdown, because a
leading tab is an indented code block and list continuation is measured in
columns. `.sql`, because a merged script is immutable, contents included
(ADR-0021), so tabs would reach new scripts only and leave the rule
disagreeing with every script already in the tree.

The per-file-type `indent_size = 2` for build files is gone rather than
carried over: a level is one tab everywhere now, so it had nothing left to
say, and leaving it would have meant something different from what it used
to mean.

`dotnet format` reaches `.cs` and nothing else, so the `.razor`
components, the build files, the stylesheets and index.html were converted
separately — one tab per former level, with continuation lines aligned
under something above them left padded in spaces, which is what keeps that
alignment at any tab width.

Nothing but whitespace changed. `git diff --ignore-all-space` is empty
across the sweep and every file keeps its exact line count, but neither
can see inside a string, where leading whitespace is content: the value of
all 668 string literals in the solution was parsed out with Roslyn before
and after and is byte-identical. `dotnet format` leaves the interior of a
multi-line raw string alone, so the SQL blocks in PlaceMark.Database and
the schema tests keep the space indentation they were written with — the
only space indentation left in any `.cs` file, and the reason none of
those SQL strings changed.

rob commented

2026-08-03 17:58:52 +00:00

Author

Owner

.editorconfig [*] comment: "There is deliberately no per-file-type size below … What each section does opt out of is tabs themselves" — [*.{yml,yaml}] and [*.json] set indent_size = 2 and [*.sql] sets indent_size = 4, so three of the four sections below do set a per-file-type size; reword, and drop [*.sql] indent_size = 4 while there, which only restates the inherited value.

Verdict: changes required

`.editorconfig` `[*]` comment: "There is deliberately no per-file-type size below … What each section does opt out of is tabs themselves" — `[*.{yml,yaml}]` and `[*.json]` set `indent_size = 2` and `[*.sql]` sets `indent_size = 4`, so three of the four sections below do set a per-file-type size; reword, and drop `[*.sql] indent_size = 4` while there, which only restates the inherited value. Verdict: changes required

rob added 1 commit

2026-08-03 18:01:03 +00:00

Say what the exemption sections actually do

CI / build (pull_request) Successful in 54s

Details

7dc4634878

The comment under `[*]` claimed there was no per-file-type size below it,
which two of the four sections under it contradict: YAML and JSON both
state two. It now says what is true — a section states a size only where
it wants one other than the four above — and records the sharper reason
the build files' `indent_size = 2` had to go rather than merely having
nothing left to say: with `indent_style = tab` and no `tab_width` of its
own, `tab_width` defaults to `indent_size`, so a tab would have rendered
two columns wide in a .csproj and four everywhere else.

`[*.sql]` no longer restates `indent_size = 4`, which it already inherits.
It read as though it were pinning something, and pinned nothing.

rob commented

2026-08-03 18:01:10 +00:00

Author

Owner

Fixed in 7dc4634: the [*] comment now says a section states a size only where it wants one other than the four above, records the tab_width-defaults-to-indent_size reason the build-file size had to go, and [*.sql] no longer restates the indent_size = 4 it inherits.

Fixed in 7dc4634: the `[*]` comment now says a section states a size only where it wants one other than the four above, records the `tab_width`-defaults-to-`indent_size` reason the build-file size had to go, and `[*.sql]` no longer restates the `indent_size = 4` it inherits.

rob commented

2026-08-03 18:04:00 +00:00

Author

Owner

.editorconfig:25-26 — "opts out of tabs for a format where a tab is illegal or means something other than indentation" holds for [*.{yml,yaml}] and [*.md] but not for [*.json] or [*.sql]: a tab is ordinary legal whitespace in both, and each of those two states a different ground three lines below it (not our file to reformat; merged scripts are immutable). Widen the sentence or drop the reason from it and leave it to the sections.

Verdict: changes required

`.editorconfig:25-26` — "opts out of tabs for a format where a tab is illegal or means something other than indentation" holds for `[*.{yml,yaml}]` and `[*.md]` but not for `[*.json]` or `[*.sql]`: a tab is ordinary legal whitespace in both, and each of those two states a different ground three lines below it (not our file to reformat; merged scripts are immutable). Widen the sentence or drop the reason from it and leave it to the sections. Verdict: changes required

rob commented

2026-08-03 18:04:13 +00:00

Author

Owner

Remove the superfluous comments in .editorconfig. There's no need for them. Also remove the indent_size properties; users should not have that enforced

Verdict: changes required

Remove the superfluous comments in `.editorconfig`. There's no need for them. Also remove the `indent_size` properties; users should not have that enforced Verdict: changes required

rob added 1 commit

2026-08-03 18:05:33 +00:00

Stop the root comment claiming a tab is illegal in JSON and SQL

CI / build (pull_request) Successful in 49s

Details

6447b150e4

It summarised all four exemptions as formats where a tab is illegal or
means something else, which is true of YAML and Markdown and false of the
other two: RFC 8259 lists %x09 in `ws`, and SQL treats a tab like any
other whitespace. Neither section claimed otherwise — one is about who
else writes the file, the other about ADR-0021 immutability — so the
summary contradicted the sections it summarised, three lines above them.

Now it says the reasons are not all of a kind and leaves the specifics to
the sections that state them.

rob commented

2026-08-03 18:05:38 +00:00

Author

Owner

Fixed in 6447b15: the summary no longer claims all four exemptions are formats where a tab is illegal — it says the reasons are not all of a kind and leaves the specifics to the sections that state them.

Fixed in 6447b15: the summary no longer claims all four exemptions are formats where a tab is illegal — it says the reasons are not all of a kind and leaves the specifics to the sections that state them.

rob commented

2026-08-03 18:07:55 +00:00

Author

Owner

Nothing to action at 6447b15.

Verdict: mergeable

Nothing to action at `6447b15`. Verdict: mergeable

rob merged commit 0fa1e41dd6 into main

2026-08-03 18:08:41 +00:00

rob referenced this pull request from a commit

2026-08-03 18:08:42 +00:00

Indent with tabs (#24)

Rows
Columns

Indent with tabs #24