THROWAWAY: does the fix survive OverlayBackdrop once the panel is fully open #174

Closed

rob wants to merge 4 commits from chore/task-233-backdrop-experiment into main

pull from: chore/task-233-backdrop-experiment

merge into: rob:main

rob:main

Conversation 2 Commits 4 Files changed 2 +79 -10

rob commented 2026-08-14 21:36:37 +00:00

Owner

Copy link

Not for merging. Reviewer of PR #173 correctly flagged that OverlayBackdrop (position: fixed; inset: 0; z-index 1299; pointer-events: auto once visible) covers the whole page above the map once the add-place panel is open, and my SecondClickX=450 fix only avoided the panel's own footprint, not the backdrop's. This branch adds one scratch test that waits 600ms (double the 300ms deferral window) before the second click, so the panel and its backdrop are unambiguously, fully open, then clicks the map at x=450. Will be closed once CI reports.

Not for merging. Reviewer of PR #173 correctly flagged that OverlayBackdrop (position: fixed; inset: 0; z-index 1299; pointer-events: auto once visible) covers the whole page above the map once the add-place panel is open, and my SecondClickX=450 fix only avoided the panel's own footprint, not the backdrop's. This branch adds one scratch test that waits 600ms (double the 300ms deferral window) before the second click, so the panel and its backdrop are unambiguously, fully open, then clicks the map at x=450. Will be closed once CI reports.

rob added 4 commits 2026-08-14 21:36:37 +00:00

Move the second click clear of the add-place panel's own footprint 15d14497e5

Retrigger CI: ConfirmationModal closing-delay test flaked under load, unrelated to this change a7d7de9dec

Retrigger CI: gather a second after-fix E2E data point for task 233 e3aae38545

THROWAWAY: does x=450 survive a fully-opened panel's own backdrop 469acf9b0f

rob commented 2026-08-14 21:46:19 +00:00

Author

Owner

Copy link

Confirmed: even 600ms after the first click (double the 300ms deferral window), a click on the page's own map at x=450 is intercepted by div.overlay-backdrop (overlay-backdrop-visible), not the panel's own content. OverlayBackdrop is position: fixed; inset: 0 with pointer-events: auto once visible, so it covers the entire viewport the instant the panel opens — no X/Y on the page map is safe once that happens. This means PR #173's coordinate change has no effect on the actual failure rate; it only relocates which element is named as the interceptor. Closing — not for merging; deleting the branch now.

Confirmed: even 600ms after the first click (double the 300ms deferral window), a click on the page's own map at x=450 is intercepted by `div.overlay-backdrop` (`overlay-backdrop-visible`), not the panel's own content. `OverlayBackdrop` is `position: fixed; inset: 0` with `pointer-events: auto` once visible, so it covers the entire viewport the instant the panel opens — no X/Y on the page map is safe once that happens. This means PR #173's coordinate change has no effect on the actual failure rate; it only relocates which element is named as the interceptor. Closing — not for merging; deleting the branch now.

rob closed this pull request 2026-08-14 21:46:24 +00:00

rob referenced this pull request 2026-08-14 21:46:43 +00:00

Make the deferred-click window overridable to fix the click-vs-panel race (task 233) #173

rob commented 2026-08-14 21:47:43 +00:00

Author

Owner

Copy link

Closing — this branch's purpose is served.

It was a throwaway experiment for task 233, forcing the second map click 600ms after the first (double the deferral window, panel unambiguously open) to test whether moving SecondClickX to 450 genuinely removed the click-vs-panel race.

It disproved the fix. The click is still intercepted, now by div.overlay-backdrop (position: fixed; inset: 0; z-index: 1299; pointer-events: auto) rather than by the panel's own content. Since the backdrop covers the whole viewport once the panel is open, no coordinate change can help — it only relocates which element is named in the failure.

That result is recorded on PR #173 (parked) and on Vikunja task 233. Branch deleted.

Closing — this branch's purpose is served. It was a throwaway experiment for task 233, forcing the second map click 600ms after the first (double the deferral window, panel unambiguously open) to test whether moving `SecondClickX` to 450 genuinely removed the click-vs-panel race. **It disproved the fix.** The click is still intercepted, now by `div.overlay-backdrop` (`position: fixed; inset: 0; z-index: 1299; pointer-events: auto`) rather than by the panel's own content. Since the backdrop covers the whole viewport once the panel is open, no coordinate change can help — it only relocates which element is named in the failure. That result is recorded on PR #173 (parked) and on Vikunja task 233. Branch deleted.

Some checks failed

Hide checks

CI / build (pull_request) Successful in 3m19s

Required

Details

CI / container-images (pull_request) Has been skipped

Required

Details

CI / e2e (pull_request) Failing after 3m10s

Required

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rob/PlaceMark!174

No description provided.