THROWAWAY: confirm task 233's fix still catches a reverted guard #172
Loading…
Reference in a new issue
No description provided.
Delete branch "chore/task-233-confirm-guard"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Not for merging. Includes task 233's fix (branch fix/task-233-distant-clicks-flake) plus a temporary revert of task 229's positional check in map.js, to confirm DistantMapClicksBothSurviveJourneyTests still reddens against it. Will be closed once CI reports.
rob referenced this pull request2026-08-14 20:56:53 +00:00
Confirmed: with the guard reverted,
TwoClicksFarApart_WithinTheDeferralWindow_BothOpenAndThenReseedTheAddPlacePanelreddens (panel never opens,#place-form-latitudenot found — the pre-ADR-0145 "second click cancels the first" shape). Task 233's updated coordinates/locator still discriminate the guard correctly. Closing this — not for merging; deleting the branch now.Proof obtained; closing as intended.
Run 626's
e2ejob on4fd30186failed on exactlyPlaceMark.E2E.Tests.DistantMapClicksBothSurviveJourneyTests.TwoClicksFarApart_WithinTheDeferralWindow_BothOpenAndThenReseedTheAddPlacePanel— 1 failed of 25.That is the result this branch existed to establish: with task 233's fix applied and task 229's positional check reverted, the test still reddens. So the flake fix has not been achieved by weakening the guard — the journey continues to discriminate the real defect it was written for, which is two deliberate adds inside the deferral window both being silently discarded.
Closing without merging, as the description said. The fix itself is PR #173.
Pull request closed