rob/CampervanHomeAssistant
Watch
1
0
Fork
You've already forked CampervanHomeAssistant
 0
Code Issues Pull requests Projects Releases 26 Packages Wiki Activity Actions

Remove coordinator pass-through methods, call stores directly #98

Merged
Claude merged 1 commit from refactor/coordinator-passthroughs into refactor/code-hygiene 2026-09-28 06:53:36 +00:00
Conversation 1 Commits 1 Files changed 12 +81 -114
Claude commented 2026-09-28 06:50:37 +00:00
Collaborator

CampervanCoordinator carried nine pass-through methods (reading, liveness, alarm, and six async_add_*_listener methods) duplicating what the stores already expose. Entities were already reaching stores directly in about 23 places, so the pass-throughs were used inconsistently.

Deletes all nine and points every caller at the owning store instead: coordinator.readings.reading/liveness/async_add_listener/async_add_node_listener, coordinator.alarms.alarm/async_add_listener, coordinator.modes.async_add_listener, coordinator.traffic.async_add_listener, coordinator.discovery.async_add_listener.

No behaviour change. Tested with tools/check (1223 passed).

CampervanCoordinator carried nine pass-through methods (reading, liveness, alarm, and six async_add_*_listener methods) duplicating what the stores already expose. Entities were already reaching stores directly in about 23 places, so the pass-throughs were used inconsistently. Deletes all nine and points every caller at the owning store instead: `coordinator.readings.reading/liveness/async_add_listener/async_add_node_listener`, `coordinator.alarms.alarm/async_add_listener`, `coordinator.modes.async_add_listener`, `coordinator.traffic.async_add_listener`, `coordinator.discovery.async_add_listener`. No behaviour change. Tested with `tools/check` (1223 passed).
Remove coordinator pass-through methods, call stores directly
All checks were successful
Lint, type check and test / hassfest (pull_request) Successful in 8s
Details
Lint, type check and test / quality (pull_request) Successful in 1m46s
Details
Lint, type check and test / release (pull_request) Has been skipped
Details
49d73804ae
Claude commented 2026-09-28 06:53:30 +00:00
Author
Collaborator

review-agent pass: clean, no findings. Verified no leftover call sites to the nine removed pass-through methods, no behaviour change in the store calls that replaced them, unused imports (Alarm, Liveness, Reading) dropped from coordinator.py, diff confined to the rename, and tools/check green (1223 passed, 3 skipped).

review-agent pass: clean, no findings. Verified no leftover call sites to the nine removed pass-through methods, no behaviour change in the store calls that replaced them, unused imports (`Alarm`, `Liveness`, `Reading`) dropped from `coordinator.py`, diff confined to the rename, and `tools/check` green (1223 passed, 3 skipped).
Claude merged commit 892839a095 into refactor/code-hygiene 2026-09-28 06:53:36 +00:00
Claude deleted branch refactor/coordinator-passthroughs 2026-09-28 06:53:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rob/CampervanHomeAssistant!98
No description provided.