Move bind actions into a per-target-type strategy #129

Merged

Claude merged 3 commits from feat/yn-11-bind-strategy into feat/yaml-nodes

2026-10-16 07:43:19 +00:00

Claude commented

2026-10-16 06:34:14 +00:00

Collaborator

Binds now picks a stateless BindStrategy from the target's endpoint type in add(). One strategy exists, on/off, for Switch, Dimmer, Fan and ColourLight; it owns source handling, mode suppression and source loss. Binds keeps source matching, heard stamping, frame decoding and the loop. add() returns false for a target type with no strategy; Node::addBind ignores that for now.

No behaviour change: test/test_binds is untouched apart from one added test for the rejection. pio test -e native: 605 -> 606 pass; pio run passes.

YN-11

Claude added 1 commit

2026-10-16 06:34:14 +00:00

Move bind actions into a per-target-type strategy

Build and test / release (pull_request) Has been cancelled

Details

Build and test / build (pull_request) Has been cancelled

Details

e5af0a1a63

Claude reviewed

2026-10-16 06:34:38 +00:00

Claude left a comment

Moved logic matches the base branch line for line. Two things to act on.

lib/node-runtime/src/node.h:56 Node::addBind ignores the new bool from Binds::add. A bind to an unsupported target type (Valve, Motor, Heater and so on) now vanishes silently. Before, it was accepted and ran the on/off logic. Return the result from addBind too, or make the rejection loud.
Binds::add dereferences bind->target before the count_ == maxBinds check. A null target now crashes at add time. Minor.

anyFollowSourceOn went public so the strategy can call it. Fine, but it widens the API.

Moved logic matches the base branch line for line. Two things to act on. 1. lib/node-runtime/src/node.h:56 `Node::addBind` ignores the new `bool` from `Binds::add`. A bind to an unsupported target type (Valve, Motor, Heater and so on) now vanishes silently. Before, it was accepted and ran the on/off logic. Return the result from `addBind` too, or make the rejection loud. 2. `Binds::add` dereferences `bind->target` before the `count_ == maxBinds` check. A null target now crashes at add time. Minor. `anyFollowSourceOn` went public so the strategy can call it. Fine, but it widens the API.

rob added 1 commit

2026-10-16 06:35:22 +00:00

Return whether Node::addBind accepted the bind

Build and test / build (pull_request) Successful in 5m14s

Details

Build and test / release (pull_request) Has been skipped

Details

149c9d6353

rob added 1 commit

2026-10-16 06:57:41 +00:00

Return the decoded bind source event by value

Build and test / build (pull_request) Successful in 2m6s