Suppress occupancy binds in Away, Travel and Night fans #126

Claude · 2026-10-15T18:59:53Z

Claude commented

2026-10-15 18:59:53 +00:00

Occupancy-sourced binds now turn nothing on in Away or Travel, and do not start a Fan-class target in Night. Clears still act; switch (EVT_BINARY) sources act in every mode. Entering Travel already switches off Light-class targets through modeSwitchesOff, so binds need no extra hook. Spec 9.5 no longer says binds act in every mode.

Tested: five new host tests in test_binds (each mode case); mutating the Night fan check and the Travel check made them fail. pio test -e native: 598 -> 603 pass; pio run passes.

YN-8

Occupancy-sourced binds now turn nothing on in Away or Travel, and do not start a Fan-class target in Night. Clears still act; switch (EVT_BINARY) sources act in every mode. Entering Travel already switches off Light-class targets through modeSwitchesOff, so binds need no extra hook. Spec 9.5 no longer says binds act in every mode. Tested: five new host tests in test_binds (each mode case); mutating the Night fan check and the Travel check made them fail. pio test -e native: 598 -> 603 pass; pio run passes. YN-8

Claude added 1 commit

2026-10-15 18:59:53 +00:00

Suppress occupancy binds in Away, Travel and Night fans

Build and test / release (pull_request) Has been cancelled

Details

Build and test / build (pull_request) Has been cancelled

Details

acbaefaef5

Claude reviewed

2026-10-15 19:00:28 +00:00

Claude left a comment

Two things to fix; the rest matches the task and spec 7 / 9.5.

lib/node-runtime/src/bind.cpp Outdated

					
				@ -45,6 +53,7 @@ void Binds::onFrame(const can::Frame& frame, uint32_t now) {

						bind.sourceOn = on;

						const bool actsOnFirstReport = bind.action == BindAction::Follow || (bind.action == BindAction::Toggle && freshPress);

						if (!wasSynced && !actsOnFirstReport) continue;

						if (fromOccupancy && on && occupancySuppressed(mode, *bind.target)) continue;

Suppressed rise still sets bind.sourceOn = true (line above), so anyFollowSourceOn() counts it. With a second Follow source on the same target (e.g. a switch), that source clearing in Away calls setOn(anyFollowSourceOn) = true and turns the light ON. Trace: PIR rises in Away (suppressed, sourceOn stays true), switch on, switch off -> light on. Fix: skip a suppressed occupancy source in anyFollowSourceOn, or don't record sourceOn when suppressed. Add a two-source test.

ToggleOnChange also flips on a clear, so an occupancy clear in Away/Travel/Night-fan turns an off target ON. Spec says clears still act, but 'turns nothing on' is violated. Either suppress ToggleOnChange occupancy fully or confirm with the spec owner it's out of scope.