Add favicon and apple touch icon #10
Loading…
Reference in a new issue
No description provided.
Delete branch "cc-13-favicon"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Replaces the empty
data:,favicon with a brand icon: orange tile, white "CC" in Fredoka 600.src/favicon.pngis 32x32 with rounded corners;src/apple-touch-icon.pngis a plain 180x180 square. Both are copied todist/bybuild.jsand linked from the head partial.Tested: new build test,
node --testpasses, html-validate clean. In Chromium vianode server.js,/favicon.pngand/apple-touch-icon.pngreturn 200image/pngand the home page logs no console errors.Ticket: CC-13
One minor point.
@ -70,0 +73,4 @@assert.ok(fs.existsSync(path.join(root, 'dist', file)), file);}const html = fs.readFileSync(path.join(root, 'dist', 'index.html'), 'utf8');assert.ok(html.includes('href="/favicon.png"'));Test only asserts the favicon link. It would still pass if the apple-touch-icon link were dropped from head.html. Add
assert.ok(html.includes('href="/apple-touch-icon.png"'));, or loop over both files for the file and link checks.