Add dimming_curve to dimmable lights and variable fans #143

Merged

Claude merged 2 commits from feat/yaml-dimming-curve into feat/yaml-nodes

2026-10-17 20:14:29 +00:00

Claude commented

2026-10-17 20:06:52 +00:00

Collaborator

YN-25. dimmable_light and variable_fan take an optional dimming_curve, one of the ctrl::Ease names in snake_case (linear, quad_in, quad_out, quad_in_out, and the same for cubic, quart and quint), default linear. The generator sets .outputEase on the PwmConfig, as the hand-written lighting node does with QuintIn for its seating and kitchen circuits; a linear curve emits nothing, so existing nodes generate the same code. The fade ease stays linear. The names come from one table in the generator that mirrors the enum in lib/node-runtime/src/easing.h, and the schema takes its enum from it. heater_blower does not take the field.

Generator, schema, README and Python tests only. The README gets the field in both type rows and a short paragraph on the names. The LOLIN32 fixture uses quint_in on its fan and quad_in_out on its ceiling light, so CI compiles two curves.

Tested: Python 144 (was 140), none skipped locally. Tests cover the mapping for a spread of names, the default and its unchanged output, an unknown name, the field being refused on a plain light, and the schema; always emitting Linear fails them. All fixtures build.

YN-25. `dimmable_light` and `variable_fan` take an optional `dimming_curve`, one of the `ctrl::Ease` names in snake_case (`linear`, `quad_in`, `quad_out`, `quad_in_out`, and the same for `cubic`, `quart` and `quint`), default `linear`. The generator sets `.outputEase` on the `PwmConfig`, as the hand-written lighting node does with `QuintIn` for its seating and kitchen circuits; a linear curve emits nothing, so existing nodes generate the same code. The fade ease stays linear. The names come from one table in the generator that mirrors the enum in `lib/node-runtime/src/easing.h`, and the schema takes its enum from it. `heater_blower` does not take the field. Generator, schema, README and Python tests only. The README gets the field in both type rows and a short paragraph on the names. The LOLIN32 fixture uses `quint_in` on its fan and `quad_in_out` on its ceiling light, so CI compiles two curves. Tested: Python 144 (was 140), none skipped locally. Tests cover the mapping for a spread of names, the default and its unchanged output, an unknown name, the field being refused on a plain light, and the schema; always emitting Linear fails them. All fixtures build.

Claude added 1 commit

2026-10-17 20:06:52 +00:00