rob/website
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Put in test fallback for manual error code. Output http mock for later verification.

Browse source
This commit is contained in:
Robert Marshall 2020-04-11 09:27:27 +01:00
parent 022de696e3
commit e389b2404a
2 changed files with 26 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Website.Tests/Data/ApiClientTests.cs
View file

@ -1,4 +1,5 @@
using System.Net.Http; using System.Net;
using System.Net.Http;
using System.Threading.Tasks; using System.Threading.Tasks;
using FluentAssertions; using FluentAssertions;
using Website.Data; using Website.Data;
@ -50,17 +51,18 @@ namespace Website.Tests.Data {
} }
[Fact] [Fact]
public void Get_WithUrlThatReturns404_ThrowsException() { public void Get_WithUrlThatReturnsError_ThrowsException() {
var httpClient = new HttpClientBuilder() var httpClient = new HttpClientBuilder()
.WithMethod(HttpMethod.Get) .WithMethod(HttpMethod.Get)
.WithUrl("/test") .WithUrl("/test")
.WithResponse("") .WithResponse("")
.WithErrorStatus(HttpStatusCode.NotFound)
.Build(); .Build();
var client = new TestApiClient(httpClient); var client = new TestApiClient(httpClient);
client.Invoking(apiClient => apiClient.Get<TestObject>("/404")).Should().Throw<ApiCallException>() client.Invoking(apiClient => apiClient.Get<TestObject>("/404")).Should().Throw<ApiCallException>()
.WithMessage("Error calling API http://example.com/404: 404, No matching mock handler for \"GET http://example.com/404\""); .WithMessage("Error calling API http://example.com/404: 404, Not Found");
} }
[Fact] [Fact]
@ -69,6 +71,7 @@ namespace Website.Tests.Data {
.WithMethod(HttpMethod.Post) .WithMethod(HttpMethod.Post)
.WithUrl("/test") .WithUrl("/test")
.WithResponse(@"{""TestProperty"":1}") .WithResponse(@"{""TestProperty"":1}")
.WithPostBody("\"value\"")
.Build(); .Build();
var expected = new TestObject {TestProperty = 1}; var expected = new TestObject {TestProperty = 1};
@ -102,11 +105,12 @@ namespace Website.Tests.Data {
.WithQueryString("query1", "1") .WithQueryString("query1", "1")
.WithQueryString("query2", "2") .WithQueryString("query2", "2")
.WithPostBody("\"value\"") .WithPostBody("\"value\"")
.Build(); .Build(out var mockHttpMessageHandler);
var client = new TestApiClient(httpClient); var client = new TestApiClient(httpClient);
(await client.Post<TestObject>("/test", "value", new {query1 = 1, query2 = 2})).Should().BeNull(); await client.Post<object>("/test", "value", new {query1 = 1, query2 = 2});
mockHttpMessageHandler.VerifyNoOutstandingExpectation();
} }
} }
} }

23
Website.Tests/HttpClientBuilder.cs
View file

@ -1,6 +1,7 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq; using System.Linq;
using System.Net;
using System.Net.Http; using System.Net.Http;
using RichardSzalay.MockHttp; using RichardSzalay.MockHttp;
@ -9,6 +10,7 @@ namespace Website.Tests {
private string _url, _response, _body; private string _url, _response, _body;
private HttpMethod _method; private HttpMethod _method;
private readonly Dictionary<string, string> _queries = new Dictionary<string, string>(); private readonly Dictionary<string, string> _queries = new Dictionary<string, string>();
private HttpStatusCode _fallbackCode = HttpStatusCode.OK;
public HttpClientBuilder WithUrl(string url) { public HttpClientBuilder WithUrl(string url) {
_url = url; _url = url;
@ -35,19 +37,28 @@ namespace Website.Tests {
return this; return this;
} }
public HttpClient Build() { public HttpClientBuilder WithErrorStatus(HttpStatusCode statusCode) {
var httpMessageHandler = new MockHttpMessageHandler(); _fallbackCode = statusCode;
return this;
}
var mockedRequest = httpMessageHandler.Expect(_method, _url).Respond("application/json", _response ?? string.Empty); public HttpClient Build(out MockHttpMessageHandler mockHttpMessageHandler) {
mockHttpMessageHandler = new MockHttpMessageHandler();
mockHttpMessageHandler.Fallback.Respond(_fallbackCode, message => message.Content = new StringContent(string.Empty));
var mockedRequest = mockHttpMessageHandler.Expect(_method, _url).Respond("application/json", _response ?? string.Empty);
if (_queries.Any()) if (_queries.Any())
mockedRequest.WithExactQueryString(_queries); mockedRequest.WithExactQueryString(_queries);
if (!string.IsNullOrEmpty(_body)) if (!string.IsNullOrEmpty(_body) || _method == HttpMethod.Post)
mockedRequest.WithContent(_body); mockedRequest.WithContent(_body ?? string.Empty);
var httpClient = httpMessageHandler.ToHttpClient(); var httpClient = mockHttpMessageHandler.ToHttpClient();
httpClient.BaseAddress = new Uri("http://example.com"); httpClient.BaseAddress = new Uri("http://example.com");
return httpClient; return httpClient;
} }
public HttpClient Build() => Build(out _);
} }
} }