rob/CampervanHomeAssistant
Watch
1
0
Fork
You've already forked CampervanHomeAssistant
 0
Code Issues Pull requests Projects Releases 26 Packages Wiki Activity Actions

Drop retired power gateway nodes and refresh codec vectors #116

Merged
rob merged 2 commits from fix/retired-power-nodes into main 2026-09-28 18:40:49 +00:00
Conversation 1 Commits 2 Files changed 4 +4 -10
Claude commented 2026-09-28 18:35:28 +00:00
Collaborator

Firmware retired NODE_VICTRON_GW (0x80), NODE_BMS_GW (0x81) and NODE_LOADS (0x82); three shared vectors now source from NODE_WATER instead.

Refreshes tests/vectors/frames.json and removes the three nodes from the Node enum and frame_bench's node table to match.

Firmware retired NODE_VICTRON_GW (0x80), NODE_BMS_GW (0x81) and NODE_LOADS (0x82); three shared vectors now source from NODE_WATER instead. Refreshes tests/vectors/frames.json and removes the three nodes from the Node enum and frame_bench's node table to match.
Remove retired VICTRON_GW, BMS_GW and LOADS nodes
All checks were successful
Lint, type check and test / hassfest (pull_request) Successful in 9s
Details
Lint, type check and test / quality (pull_request) Successful in 1m48s
Details
Lint, type check and test / release (pull_request) Has been skipped
Details
5a35a795dc
Claude reviewed 2026-09-28 18:37:43 +00:00
Claude left a comment

Checked the vector diff (only the three id fields move from 0x81 to 0x40, no data/dlc/field changes), grepped for any remaining reference to VICTRON_GW/BMS_GW/LOADS or their hex values as node identifiers (none found), and checked the two places that iterate the whole Node enum (tests/test_node_file_server.py) — WATER_HEATER (12 chars) stays the longest name so the path-length test is unaffected, and the manifest-overflow test still overflows with 13 nodes. Ran the full suite locally: 1223 passed, 3 skipped, ruff/ruff format/mypy all clean, matching what's reported in the PR. Nothing to act on.

Checked the vector diff (only the three `id` fields move from 0x81 to 0x40, no data/dlc/field changes), grepped for any remaining reference to VICTRON_GW/BMS_GW/LOADS or their hex values as node identifiers (none found), and checked the two places that iterate the whole `Node` enum (`tests/test_node_file_server.py`) — `WATER_HEATER` (12 chars) stays the longest name so the path-length test is unaffected, and the manifest-overflow test still overflows with 13 nodes. Ran the full suite locally: 1223 passed, 3 skipped, ruff/ruff format/mypy all clean, matching what's reported in the PR. Nothing to act on.
rob merged commit f0c19b07ea into main 2026-09-28 18:40:49 +00:00
rob deleted branch fix/retired-power-nodes 2026-09-28 18:40:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rob/CampervanHomeAssistant!116
No description provided.