Robware/lib.apiclient
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

A little bit of clean up

Browse source
This commit is contained in:
Robert Marshall 2021-07-23 22:05:29 +01:00
parent f79cd3dad4
commit 8b5185847d
4 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/Robware.Lib.ApiClient.Tests/ApiClientTests.cs
View file

@ -4,7 +4,6 @@ using System.Threading.Tasks;
using FluentAssertions; using FluentAssertions;
using Microsoft.Extensions.Caching.Memory; using Microsoft.Extensions.Caching.Memory;
using NSubstitute; using NSubstitute;
using Robware.Lib.ApiClient;
using Xunit; using Xunit;
namespace Robware.Lib.ApiClient.Tests { namespace Robware.Lib.ApiClient.Tests {

1
src/Robware.Lib.ApiClient.Tests/CacheDurationsTests.cs
View file

@ -1,6 +1,5 @@
using System.Collections.Generic; using System.Collections.Generic;
using FluentAssertions; using FluentAssertions;
using Robware.Lib.ApiClient;
using Xunit; using Xunit;
namespace Robware.Lib.ApiClient.Tests { namespace Robware.Lib.ApiClient.Tests {

4
src/Robware.Lib.ApiClient/ApiCallException.cs
View file

@ -3,7 +3,9 @@ using System.Net.Http;
namespace Robware.Lib.ApiClient { namespace Robware.Lib.ApiClient {
public class ApiCallException : Exception { public class ApiCallException : Exception {
private readonly HttpResponseMessage Response; // ReSharper disable once NotAccessedField.Local
// ReSharper disable once MemberCanBePrivate.Global
public readonly HttpResponseMessage Response;
public ApiCallException(HttpResponseMessage response):base($"Error calling API {response.RequestMessage.RequestUri}: {(int)response.StatusCode}, {response.ReasonPhrase}") { public ApiCallException(HttpResponseMessage response):base($"Error calling API {response.RequestMessage.RequestUri}: {(int)response.StatusCode}, {response.ReasonPhrase}") {
Response = response; Response = response;

4
src/Robware.Lib.ApiClient/ApiClient.cs
View file

@ -21,10 +21,10 @@ namespace Robware.Lib.ApiClient {
_cacheDurations = cacheDurations; _cacheDurations = cacheDurations;
} }
private IDictionary<string, string> ParseQueryParameters(object query) { private static IDictionary<string, string> ParseQueryParameters(object query) {
var type = query.GetType(); var type = query.GetType();
var props = type.GetProperties(); var props = type.GetProperties();
return props.ToDictionary(info => info.Name, info => info.GetValue(query, null).ToString()); return props.ToDictionary(info => info.Name, info => info.GetValue(query, null)?.ToString());
} }
private async Task<TResult> DoCachedCall<TResult>(string callerName, string url, bool skipCache, Func<Task<TResult>> call) { private async Task<TResult> DoCachedCall<TResult>(string callerName, string url, bool skipCache, Func<Task<TResult>> call) {